Upgrade to Kotlin 1.9 #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several libraries have been upgraded: - ktor to 2.3.7 - kotlinx.coroutines to 1.7.3 - kotlinx.serialization to 1.6.2 tor-mobile-kmp and secp256k1 have been also upgraded to development version using kotlin 1.9 (we'll use tags before this commit is merged to master). Note: the `iosSimulatorArm64` target has been removed for now as it's not yet supported by tor-mobile-kmp. This will be reverted once the tor library is fixed. The kodein-memory library has also been removed. This library was used to write the logs to disk in the shared module. However we were using an old version, and we are already planning to move to another log library and to delegate writing logs to disk to the application layer. It's not worth spending time upgrading ; instead this dependency is removed, and the code should be cleaned up: -> removed LogMemory -> removed usage of APIs from this lib (freeze calls) -> remove most code from the LogConfiguration controller which has to be removed (will be done in another commit as the UI would be impacted)
Also target api 34 in the Android apps.
Using kotlin 1.9 requires the Android dependencies to upgrade as well.
dpad85
commented
Jan 22, 2024
phoenix-shared/src/commonMain/kotlin/fr.acinq.phoenix/db/payments/MetadataTypes.kt
Show resolved
Hide resolved
phoenix-shared/src/iosMain/kotlin/fr/acinq/phoenix/db/CloudKitDb.kt
Outdated
Show resolved
Hide resolved
|
Note: we're having CI issue with tor-mobile-kmp 1.9 so we won't upgrade this library now, it will be done later in a future PR. |
These dependencies are resolved transitively.
pm47
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades kotlin to version 1.9, which has side effects :
secp256k1,lightning-kmp;LogMemory).It also brings several improvements:
Libraries update
lightning-kmpis using a development version.About
iosSimulatorArm64The
iosSimulatorArm64target has been removed for now as it's not yet supported bytor-mobile-kmp.Removing
LogMemoryThe
kodein-memorylibrary has also been removed. This library was used to write the logs to disk in the shared module. However we were using an old version, and we are already planning to move to another log library and to delegate writing logs to disk to the application layer (*).So it's not worth spending time upgrading this library ; instead this dependency is removed, and the code has be cleaned up:
LogMemoryLogConfigurationcontroller, which will have to be removed altogether at some point(*) I think that delegating writing logs to disk should help with performances.